Update auto-join to try channel name prefixes #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this allows categorizing not just by top-level category in Discord, but also refining by a channel prefix. As an example, a channel #mezo-engineering-musd in the Mezo category would previously only auto-join the roles "Mezo Engineering mUSD" and "Mezo", because one would match the channel and one the category. The new approach tries all prefixes of the channel name, so that "Mezo Engineering" can also be auto-tagged. With the current Discord channel name structure, this means most items will be auto-tagged in this phase instead of by category, since project channels always prefix their project name. One key exception is Studio.
Without this, the autotagger was not tagging due to +2 entries on tags.
zuuring
approved these changes
Jul 22, 2024
| .reduce( | ||
| (allPrefixes, nameSegment) => [ | ||
| ...allPrefixes, | ||
| `${allPrefixes.at(-1) ?? []} ${nameSegment}`.trim(), |
There was a problem hiding this comment.
Just added .trim() here since on local test, roles were being outputted in some cases role here, role here is, role here there, otherwise let's merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this allows categorizing not just by top-level category in Discord, but also refining by a channel prefix. As an example, a channel #mezo-engineering-musd in the Mezo category would previously only auto-join the roles "Mezo Engineering mUSD" and "Mezo", because one would match the channel and one the category.
The new approach tries all prefixes of the channel name, so that "Mezo Engineering" can also be auto-tagged.
With the current Discord channel name structure, this means most items will be auto-tagged in this phase instead of by category, since project channels always prefix their project name. One key exception is Studio.